This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 19/22] Convert tid_range_parser to class
- From: Trevor Saunders <tbsaunde at tbsaunde dot org>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 4 Oct 2016 22:25:14 -0400
- Subject: Re: [RFA 19/22] Convert tid_range_parser to class
- Authentication-results: sourceware.org; auth=none
- References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-20-git-send-email-tom@tromey.com> <55f2924c-f8f9-6c06-ffbb-69079b6ffa62@redhat.com> <87shsha3bf.fsf@tromey.com> <926126cb-b3c5-340b-ac1c-5bc14ca41bf9@redhat.com> <42bd9696-cea5-5f39-ce03-1b223b5ed6fc@redhat.com> <5cae4120-3581-b3ca-b323-44d8788e2916@redhat.com>
On Wed, Oct 05, 2016 at 12:09:13AM +0100, Pedro Alves wrote:
> On 10/04/2016 08:24 PM, Pedro Alves wrote:
>
> > Anyway, I have to disappear now. Will continue later.
>
> Here's what I ended up with, after reading your version
> in more detail. That brought in the "deleted" copy constructor/assignment
> operators [1], and "const" in several methods, which I then propagated
> to number_or_range_parser too.
>
> WDYT?
>
> [1] - I'm pondering making those use =delete if compiling with
> a C++ compiler, behind some
>
> #define DISABLE_COPY_AND_ASSIGN(TYPE) ...
>
> macro.
>
> Or, maybe add a gdb::noncopyable class that non-copyable
> classes inherit from privately, just like boost:noncopyable.
> Anyone got experience on the latter, and whether that turns
> out to be a bad idea?
when Mozilla supported compilers without = delete there was a MOZ_DELETE
macro that was defined to "= delete" when available, but I've never delt
with the latter style.
Trev