This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] Add ILP32 support to gdb.

From: Andreas Schwab <schwab at suse dot de>
To: Andrew Pinski <apinski at cavium dot com>
Cc: gdb-patches at sourceware dot org, binutils at sourceware dot org
Date: Tue, 30 Aug 2016 09:44:05 +0200
Subject: Re: [PATCH 2/3] Add ILP32 support to gdb.
Authentication-results: sourceware.org; auth=none
References: <1472516750-30743-1-git-send-email-apinski@cavium.com> <1472516750-30743-3-git-send-email-apinski@cavium.com>

On Aug 30 2016, Andrew Pinski <apinski@cavium.com> wrote:

> @@ -2695,6 +2696,11 @@ aarch64_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
>        return NULL;
>      }
>  
> +  if (info.abfd
> +      && bfd_get_flavour (info.abfd) == bfd_target_elf_flavour
> +      && elf_elfheader (info.abfd)->e_ident[EI_CLASS] == ELFCLASS32)
> +    ilp32 = TRUE;
> +

Shouldn't this use bfd_arch_bits_per_address?

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

References:
- [PATCH 0/3] Support AARCH64 ILP32 for gdb
  - From: Andrew Pinski
- [PATCH 2/3] Add ILP32 support to gdb.
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]