This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] btrace, testsuite: fix assembly source file selection
- From: Pedro Alves <palves at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>, gdb-patches at sourceware dot org
- Cc: jan dot kratochvil at redhat dot com
- Date: Tue, 26 Jul 2016 09:41:24 +0100
- Subject: Re: [PATCH] btrace, testsuite: fix assembly source file selection
- Authentication-results: sourceware.org; auth=none
- References: <1469516752-32313-1-git-send-email-markus.t.metzger@intel.com>
On 07/26/2016 08:05 AM, Markus Metzger wrote:
> Some btrace tests use assembly source files. They use the target triplet to
> distinguish between x86_64 and ia32 ISA. This does not work for -m32 tests
> without setting the target triplet to i686-?-?.
>
> Instead use is_amd64_regs_target to distinguish between x86_64 and ia32 ISA.
>
> See also https://sourceware.org/ml/gdb-patches/2016-07/msg00256.html.
>
> 2016-07-26 Markus Metzger <markus.t.metzger@intel.com>
>
> testsuite/
> * gdb.btrace/record_goto.exp: Use is_amd64_regs_target for selecting
> assembly source files.
> * gdb.btrace/stepi.exp: Use is_amd64_regs_target for selecting
> assembly source files.
> * gdb.btrace/tailcall.exp: Use is_amd64_regs_target for selecting
> assembly source files.
> * gdb.btrace/tailcall-only.exp: Use is_amd64_regs_target for selecting
> assembly source files.
LGTM.
Thanks,
Pedro Alves