This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] fortran: Print logical values as either .FALSE. or .TRUE.


A Logical value in Fortran may be either .FALSE. or .TRUE.
When converting from integer, a subset of compilers evaluate
the whole value, while others only check if the least significant
bit is set.  This patch unifies the printing output by evaluating
only the lsb.

2014-03-25  Christoph Weinmann  <christoph.t.weinmann@intel.com>

	* f-valprint.c (f_val_print): Print .FALSE. when the lsb
	is '0'.  Print .TRUE. in all other cases.


Signed-off-by: Christoph Weinmann <christoph.t.weinmann@intel.com>
---
 gdb/f-valprint.c |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)

diff --git a/gdb/f-valprint.c b/gdb/f-valprint.c
index b6d1ab9..06154d1 100644
--- a/gdb/f-valprint.c
+++ b/gdb/f-valprint.c
@@ -350,6 +350,20 @@ f_val_print (struct type *type, const gdb_byte *valaddr, int embedded_offset,
       fprintf_filtered (stream, " )");
       break;     
 
+    case TYPE_CODE_BOOL:
+      {
+	int val = unpack_long (type, valaddr + embedded_offset);
+	/* As a superset of compilers treat logical values
+	  differently (e.g. .TRUE. can be "-1" or "1", the
+	  common baseline is to evaluate if the least
+	  significant bit is set or not.  */
+	if ((val & 1) == 0)
+	  fputs_filtered (f_decorations.false_name, stream);
+	else
+	  fputs_filtered (f_decorations.true_name, stream);
+      }
+      break;
+
     case TYPE_CODE_REF:
     case TYPE_CODE_FUNC:
     case TYPE_CODE_FLAGS:
@@ -359,7 +373,6 @@ f_val_print (struct type *type, const gdb_byte *valaddr, int embedded_offset,
     case TYPE_CODE_RANGE:
     case TYPE_CODE_UNDEF:
     case TYPE_CODE_COMPLEX:
-    case TYPE_CODE_BOOL:
     case TYPE_CODE_CHAR:
     default:
       generic_val_print (type, valaddr, embedded_offset, address,
-- 
1.7.0.7


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]