This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[pushed] Re: Missing test cases for jit-reader interface
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, Andy Wingo <wingo at igalia dot com>
- Cc: gdb-patches at sourceware dot org, jan dot kratochvil at redhat dot com, sanjoyd at sourceware dot org
- Date: Fri, 17 Jun 2016 19:56:21 +0100
- Subject: [pushed] Re: Missing test cases for jit-reader interface
- Authentication-results: sourceware.org; auth=none
- References: <87oaolx6xy dot fsf at igalia dot com> <87k2z8ydq4 dot fsf at igalia dot com> <86y4nmvvme dot fsf at gmail dot com>
The subject of missing jit reader tests came up again:
https://sourceware.org/ml/gdb-patches/2016-06/msg00202.html
I've now pushed this in, with a couple trivial modifications mentioned
below.
I left the test arch specific as it was, thinking that it can always
be cleaned up with follow up patches.
On 02/25/2015 03:50 PM, Yao Qi wrote:
> Andy Wingo <wingo@igalia.com> writes:
>
>> I think it was Sanjoy who forgot to commit these. Anyway, here is an
>> updated version of the same patch, which passes tests for me. WDYT?
>>
>
> Yes, we should add them back since they were reviewed and approved.
> It should be moved into jit_reader_test, after clean_restart, otherwise,
> we'll get the following errors if I run it with --target_board=native-gdbserver.
I did this.
>
> ERROR: tcl error sourcing /home/yao/SourceCode/gnu/gdb/git/gdb/testsuite/gdb.base/jit-reader.exp.
> ERROR: can't read "use_gdb_stub": no such variable
(...)
and also adjusted the number of "../"'s in :
> set jit_reader_header [standard_output_file "../../../gdb/jit-reader.h"]
since the standard output directory moved under testsuite/outputs/ meanwhile.
Thanks,
Pedro Alves