This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 3/3] Move logic out of symbol_find_demangled_name
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 07 Jun 2016 20:14:16 -0600
- Subject: Re: [RFA 3/3] Move logic out of symbol_find_demangled_name
- Authentication-results: sourceware.org; auth=none
- References: <1465051760-25840-1-git-send-email-tom at tromey dot com> <1465051760-25840-4-git-send-email-tom at tromey dot com> <86mvmywgj1 dot fsf at gmail dot com> <fc8fa5a8-b9db-287f-ba8e-7464ac9e9bc9 at redhat dot com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> So IMHO, something like "la_sniff_from_mangled_name" would be
Pedro> even clearer.
I made this change.
Pedro> BTW, what do we do with the resulting demangled name? Is
Pedro> there some sort of guideline for options to pass to the demangler?
Pedro> Some sort of output that we're aiming for?
The resulting name, if any, is put into a symbol by symbol_set_names.
(I didn't change this area, just made it so the existing code could be
factored into per-language methods.)
So, it should be whatever is appropriate for a symbol.
I think this area is still a bit messy. IIRC there are some weird
demangling differences between psymbols and full symbols, and there is
still a hack for Java in symbol_set_names.
Tom