This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/5 v2] Move trace conditions tests from ftrace.exp to trace-condition.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Mon, 30 May 2016 12:01:50 +0100
- Subject: Re: [PATCH 2/5 v2] Move trace conditions tests from ftrace.exp to trace-condition.exp
- Authentication-results: sourceware.org; auth=none
- References: <1464375916-16369-1-git-send-email-antoine dot tremblay at ericsson dot com> <1464375916-16369-2-git-send-email-antoine dot tremblay at ericsson dot com>
On 05/27/2016 08:05 PM, Antoine Tremblay wrote:
> This patch moves conditional tests that were done in ftrace.exp to
> trace-condition.exp.
>
> Note that emit_ref is now tested by the anarg local variable there is no
> need to test the register directly.
>
> All emit calls have been tested using asserts before / after the move, so
> that the tests cover the same functions.
ITYM s/so that/to ensure that/
LGTM.
Thanks,
Pedro Alves