This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/5 v2] Move trace conditions tests from ftrace.exp to trace-condition.exp


On 05/27/2016 08:05 PM, Antoine Tremblay wrote:
> This patch moves conditional tests that were done in ftrace.exp to
> trace-condition.exp.
> 
> Note that emit_ref is now tested by the anarg local variable there is no
> need to test the register directly.
> 
> All emit calls have been tested using asserts before / after the move, so
> that the tests cover the same functions.

ITYM s/so that/to ensure that/

LGTM.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]