This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] Move trace conditions tests from ftrace.exp to trace-condition.exp
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, <gdb-patches at sourceware dot org>
- Date: Fri, 27 May 2016 08:51:06 -0400
- Subject: Re: [PATCH 1/4] Move trace conditions tests from ftrace.exp to trace-condition.exp
- Authentication-results: sourceware.org; auth=none
- References: <1463504594-4419-1-git-send-email-antoine dot tremblay at ericsson dot com> <b5a368d3-91ab-2ed2-4a73-efe792d9e88c at redhat dot com> <wwokshx3vfu8 dot fsf at ericsson dot com> <af96f633-8225-75ee-a0a4-0b40bb40d372 at redhat dot com>
Pedro Alves writes:
> On 05/27/2016 01:35 PM, Antoine Tremblay wrote:
>>
>> Pedro Alves writes:
>>
>>> On 05/17/2016 06:03 PM, Antoine Tremblay wrote:
>
>>>> The test coverage remains the same.
>>>
>>> How did you determine it that it's the same?
>>
>> I've put an assert in each emit function and validated that they are all
>> called before / after the move.
>
> That's excellent, and it's the sort of info that should be
> explicitly mentioned in the commit log.
OK.