This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] Fortran, typeprint: Fix wrong indentation when ptype nested structures.
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Bernhard Heckel <bernhard dot heckel at intel dot com>
- Cc: qiyaoltc at gmail dot com, gdb-patches at sourceware dot org
- Date: Wed, 11 May 2016 12:58:13 +0100
- Subject: Re: [PATCH 1/4] Fortran, typeprint: Fix wrong indentation when ptype nested structures.
- Authentication-results: sourceware.org; auth=none
- References: <1462889739-30359-1-git-send-email-bernhard dot heckel at intel dot com> <1462889739-30359-2-git-send-email-bernhard dot heckel at intel dot com>
Bernhard Heckel <bernhard.heckel@intel.com> writes:
> diff --git a/gdb/testsuite/gdb.fortran/whatis_type.exp b/gdb/testsuite/gdb.fortran/whatis_type.exp
> index af897a6..edaf4fd 100644
> --- a/gdb/testsuite/gdb.fortran/whatis_type.exp
> +++ b/gdb/testsuite/gdb.fortran/whatis_type.exp
> @@ -39,15 +39,25 @@ set t1_i "$int :: t1_i"
> set t1_r "$real :: t1_r"
>
> gdb_test "whatis t1" \
> - "type = Type t1\r\n${t1_i}\r\n${t1_r}\r\nEnd Type t1" \
> - "whatis t1"
> + [multi_line "type = Type t1" \
> + " $t1_i" \
> + " $t1_r" \
> + "End Type t1"]
> +
> gdb_test "whatis t1v" \
> - "type = Type t1\r\n${t1_i}\r\n${t1_r}\r\nEnd Type t1" \
> - "whatis t1v"
> + [multi_line "type = Type t1" \
> + " $t1_i" \
> + " $t1_r" \
> + "End Type t1"]
>
> gdb_test "ptype t1" \
> - "type = Type t1\r\n ${t1_i}\r\n ${t1_r}\r\nEnd Type t1" \
> - "ptype t1"
> + [multi_line "type = Type t1" \
> + " $t1_i" \
> + " $t1_r" \
> + "End Type t1"]
> +
> gdb_test "ptype t1v" \
> - "type = Type t1\r\n ${t1_i}\r\n ${t1_r}\r\nEnd Type t1" \
> - "ptype t1v"
> + [multi_line "type = Type t1" \
> + " $t1_i" \
> + " $t1_r" \
> + "End Type t1"]
Could you please split your patch to two parts? The first part is to
change test case using multi_line, and the second part is to adjust the
indentation of expected output in the test.
Looks your patch only affects the output of "whatis".
--
Yao (éå)