This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, gdb, ARM] Use getters/setters to access ARM branch type
- From: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 10 May 2016 16:32:12 +0100
- Subject: Re: [PATCH, gdb, ARM] Use getters/setters to access ARM branch type
- Authentication-results: sourceware.org; auth=none
- References: <3219422 dot otqiV2U3aN at e108577-lin> <86eg9adk20 dot fsf at gmail dot com>
On Tuesday 10 May 2016 16:11:51 Yao Qi wrote:
> Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:
> > @@ -8467,7 +8467,8 @@ coff_sym_is_thumb (int val)
> >
> > static void
> > arm_elf_make_msymbol_special(asymbol *sym, struct minimal_symbol *msym)
> > {
> >
> > - if (ARM_SYM_BRANCH_TYPE (&((elf_symbol_type *)sym)->internal_elf_sym)
> > + elf_symbol_type *elfsym = (elf_symbol_type *) sym;
>
> We need a blank line here.
>
> > + if (ARM_GET_SYM_BRANCH_TYPE
> > (elfsym->internal_elf_sym.st_target_internal)>
> > == ST_BRANCH_TO_THUMB)
> >
> > MSYMBOL_SET_SPECIAL (msym);
>
> Patch is OK to me.
Committed with the above changes.
Thanks. Best regards,
Thomas