This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Match shell_prompt # in batch-preserve-term-settings.exp
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Tue, 10 May 2016 13:02:07 +0100
- Subject: Re: [PATCH] Match shell_prompt # in batch-preserve-term-settings.exp
- Authentication-results: sourceware.org; auth=none
- References: <1462877837-31075-1-git-send-email-yao dot qi at linaro dot org> <mvmoa8ecfyk dot fsf at hawking dot suse dot de>
Andreas Schwab <schwab@suse.de> writes:
>> # The shell's prompt.
>> -set shell_prompt "$ "
>> -set shell_prompt_re [string_to_regexp $shell_prompt]
>> +set shell_prompt_re "\[$|#\] "
>
> Did you intent to match "|" too?
Ur, no, that is not intended. "|" should be removed from
shell_prompt_re.
--
Yao (éå)
Subject: [PATCH] Match shell_prompt # in batch-preserve-term-settings.exp
batch-preserve-term-settings.exp fails if the shell prompt isn't $. It
is # in our testing env. In fact, the shell prompt can be anything.
The perfect solution would be "set_board_info shell_prompt" in the
host board file, and use board_info shell_prompt in
batch-preserve-term-settings.exp. This is a little bit overkill to
me, and we still need to figure out the different prompts on different
shells. I also tried to start shell with the prompt preset, but there is
not unique way to set shell prompt in different shells, so I give up.
It is reasonably simple to match either $ or # for the shell prompt, and
we can easily extend it to match other char, like >.
gdb/testsuite:
2016-05-10 Yao Qi <yao.qi@linaro.org>
* gdb.base/batch-preserve-term-settings.exp: Remove variable
shell_prompt. Update shell_prompt_re.
diff --git a/gdb/testsuite/gdb.base/batch-preserve-term-settings.exp b/gdb/testsuite/gdb.base/batch-preserve-term-settings.exp
index c925e88..a2de2c0 100644
--- a/gdb/testsuite/gdb.base/batch-preserve-term-settings.exp
+++ b/gdb/testsuite/gdb.base/batch-preserve-term-settings.exp
@@ -28,8 +28,7 @@ if [is_remote host] {
}
# The shell's prompt.
-set shell_prompt "$ "
-set shell_prompt_re [string_to_regexp $shell_prompt]
+set shell_prompt_re "\[$#\] "
# Spawn shell. Returns true on success, false otherwise.