This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, committed] remove trivialy unused variables
- From: Trevor Saunders <tbsaunde at tbsaunde dot org>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: tbsaunde+binutils at tbsaunde dot org, gdb-patches at sourceware dot org
- Date: Mon, 9 May 2016 21:10:05 -0400
- Subject: Re: [PATCH, committed] remove trivialy unused variables
- Authentication-results: sourceware.org; auth=none
- References: <1462666464-7737-1-git-send-email-tbsaunde+binutils at tbsaunde dot org> <86a8jzd6ku dot fsf at gmail dot com>
On Mon, May 09, 2016 at 08:38:25AM +0100, Yao Qi wrote:
> tbsaunde+binutils@tbsaunde.org writes:
>
> > @@ -206,8 +206,6 @@ iq2000_scan_prologue (struct gdbarch *gdbarch,
> > struct symtab_and_line sal;
> > CORE_ADDR pc;
> > CORE_ADDR loop_end;
> > - int found_store_lr = 0;
> > - int found_decr_sp = 0;
> > int srcreg;
> > int tgtreg;
> > signed short offset;
> > @@ -251,7 +249,6 @@ iq2000_scan_prologue (struct gdbarch *gdbarch,
> > cache->saved_regs[tgtreg] = -((signed short) (insn & 0xffff));
> >
> > if (tgtreg == E_LR_REGNUM)
> > - found_store_lr = 1;
>
> We should remove line "if (tgtreg == E_LR_REGNUM)" as well, otherwise,
> the code behavior is changed.
ouch, not sure how me and Pedro both missed that :( I'll send a fix
tonight.
Trev
>
> > continue;
> > }
> >
>
> --
> Yao (éå)