This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, committed] remove trivialy unused variables
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: tbsaunde+binutils at tbsaunde dot org
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 09 May 2016 08:51:05 +0100
- Subject: Re: [PATCH, committed] remove trivialy unused variables
- Authentication-results: sourceware.org; auth=none
- References: <1462666464-7737-1-git-send-email-tbsaunde+binutils at tbsaunde dot org>
tbsaunde+binutils@tbsaunde.org writes:
> diff --git a/gdb/linespec.c b/gdb/linespec.c
> index 2360cc1..c0c3b3b3 100644
> --- a/gdb/linespec.c
> +++ b/gdb/linespec.c
> @@ -845,8 +845,6 @@ add_sal_to_sals (struct linespec_state *self,
> canonical = &self->canonical_names[sals->nelts - 1];
> if (!literal_canonical && sal->symtab)
> {
> - const char *fullname = symtab_to_fullname (sal->symtab);
> -
Variable fullname isn't used, but I am not sure we can remove the call
to symtab_to_fullname. At least, symtab_to_fullname sets
sal->symtab->fullname, and we have this some lines below,
canonical->symtab = sal->symtab;
--
Yao (éå)