This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 04/25] Introduce interpreter factories
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 6 May 2016 12:49:20 +0100
- Subject: Re: [PATCH v2 04/25] Introduce interpreter factories
- Authentication-results: sourceware.org; auth=none
- References: <1458573675-15478-1-git-send-email-palves at redhat dot com> <1458573675-15478-5-git-send-email-palves at redhat dot com> <86zitqvqlo dot fsf at gmail dot com>
Finally getting back to this...
On 03/22/2016 08:55 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> +void
>> +interp_factory_register (const char *name, interp_factory_func func)
>> +{
>> + struct interp_factory *f = XNEW (struct interp_factory);
>> +
>> + f->name = name;
>> + f->func = func;
>> +
>> + /* FIXME: assert that no factory for NAME is already registered. */
>> + VEC_safe_push (interp_factory_p, interpreter_factories, f);
>> +}
>
> It shouldn't be hard to do the assert here, and get rid of the FIXME.
>
Indeed. I fixed this for v3.
Thanks,
Pedro Alves