This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT
- From: Pedro Alves <palves at redhat dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Tom Tromey <tom at tromey dot com>, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Wed, 27 Apr 2016 14:39:02 +0100
- Subject: Re: [PATCH] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT
- Authentication-results: sourceware.org; auth=none
- References: <1461707298-26514-1-git-send-email-martin dot galvan at tallertechnologies dot com> <57208DFF dot 3020801 at redhat dot com> <CAOKbPbY_NuRyB_HJsLHLJjXT_UsSWFJxwuVpdxxUnLFxkBvSLQ at mail dot gmail dot com>
On 04/27/2016 02:21 PM, Martin Galvan wrote:
> On Wed, Apr 27, 2016 at 7:01 AM, Pedro Alves <palves@redhat.com> wrote:
>> What's the motivation behind this? Does it change anything user visible?
>
> AFAIK not directly, but I'm going to need it for the synthetic reference bug
> fix.
I see.
> Since this is an isolated change I thought I could send it for
> review now.
Since you didn't mention whether the change had any user-visible
impact, I was left wondering if we could add a testcase to
the testsuite that exposes the need for the change. From the original
log it kind of sounded like it would be possible.
It's better to be explicit in such cases, and say something like,
"this has no effect currently, so can be seen as a small code
cleanup, but once we do X, we'll print the wrong thing", or some such,
and mention that this causes no testsuite regressions, in the
email/commit log.
The code change is OK.
Thanks,
Pedro Alves