This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V2 1/3] fort_dyn_array: Enable dynamic member types inside a structure.
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Bernhard Heckel <bernhard dot heckel at intel dot com>
- Cc: gdb-patches at sourceware dot org, brobecker at adacore dot com
- Date: Thu, 07 Apr 2016 17:18:49 +0100
- Subject: Re: [PATCH V2 1/3] fort_dyn_array: Enable dynamic member types inside a structure.
- Authentication-results: sourceware.org; auth=none
- References: <1459936659-19039-1-git-send-email-bernhard dot heckel at intel dot com> <1459936659-19039-2-git-send-email-bernhard dot heckel at intel dot com>
Bernhard Heckel <bernhard.heckel@intel.com> writes:
Hi Bernhard,
Patch is good to me, two nits below,
> + /* If type has a dynamic resolved location property update it's value address. */
This line is too long.
> + type = value_type (whole);
> + if (TYPE_DATA_LOCATION (type)
> + && TYPE_DATA_LOCATION_KIND (type) == PROP_CONST)
> + set_value_address (component, TYPE_DATA_LOCATION_ADDR (type));
> }
>
> -
> /* Access to the value history. */
>
> /* Record a new value in the value history.
> @@ -2416,6 +2428,12 @@ set_internalvar (struct internalvar *var, struct value *val)
> call error () until new_data is installed into the var->u to avoid
> leaking memory. */
> release_value (new_data.value);
> +
> + /* Internal variables which are created from values with a dynamic location
This line is too long.
> + don't need the location property of the origin anymore.
> + Remove the location property in case it exist. */
> + remove_dyn_prop (DYN_PROP_DATA_LOCATION, value_type (new_data.value));
--
Yao (éå)