This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4 09/11] [PR gdb/14441] gdb: convert lvalue reference type check to general reference type check
- From: Keith Seitz <keiths at redhat dot com>
- To: Artemiy Volkov <artemiyv at acm dot org>, "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Thu, 31 Mar 2016 13:36:57 -0700
- Subject: Re: [PATCH v4 09/11] [PR gdb/14441] gdb: convert lvalue reference type check to general reference type check
- Authentication-results: sourceware.org; auth=none
- References: <1457147955-21871-1-git-send-email-artemiyv at acm dot org> <1458593958-25656-1-git-send-email-artemiyv at acm dot org> <1458593958-25656-10-git-send-email-artemiyv at acm dot org>
One more (very very) small nit; please repost this single patch for
final maintainer review.
On 03/21/2016 01:59 PM, Artemiy Volkov wrote:
> diff --git a/gdb/valops.c b/gdb/valops.c
> index 1f423a0..2f1fca2 100644
> --- a/gdb/valops.c
> +++ b/gdb/valops.c
[snip]
> @@ -1716,7 +1712,7 @@ typecmp (int staticp, int varargs, int nargs,
> tt1 = check_typedef (t1[i].type);
> tt2 = check_typedef (value_type (t2[i]));
>
> - if (TYPE_CODE (tt1) == TYPE_CODE_REF
> + if ((TYPE_IS_REFERENCE (tt1))
> /* We should be doing hairy argument matching, as below. */
> && (TYPE_CODE (check_typedef (TYPE_TARGET_TYPE (tt1)))
> == TYPE_CODE (tt2)))
Looks like an extra set of parentheses sneaked in here.
Yup, that's it!
Keith