This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH] python: Use console format for output of gdb.execute command
- From: Catalin-Dan Udma <catalin-dan dot udma at nxp dot com>
- To: Pedro Alves <palves at redhat dot com>, Catalin Udma <catalin dot udma at freescale dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 31 Mar 2016 10:42:58 +0000
- Subject: RE: [PATCH] python: Use console format for output of gdb.execute command
- Authentication-results: sourceware.org; auth=none
- Authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nxp.com;
- References: <1456756452-15880-1-git-send-email-catalin dot udma at freescale dot com> <56FAAFD6 dot 8030705 at redhat dot com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:23
Hi,
I'll fix the comments in patch v2.
Please see my comments inline.
Thank you,
Catalin
> > }
> >
> > + /* Restore the saved uiout. */
> > + current_uiout = saved_uiout;
>
> This needs to be restored with a cleanup instead.
[Udma Catalin-Dan] I did not find a cleanup used for struct ui_out. For this purpose
I'll add a new cleanup handler for it in gdb/utils.c and may be re-used in other locations.