This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] gdbserver/IPA: Export some functions via global function pointers.
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: palves at redhat dot com (Pedro Alves)
- Cc: koriakin at 0x04 dot net (Marcin KoÅcielnicki), gdb-patches at sourceware dot org
- Date: Wed, 30 Mar 2016 13:30:06 +0200 (CEST)
- Subject: Re: [PATCH 1/3] gdbserver/IPA: Export some functions via global function pointers.
- Authentication-results: sourceware.org; auth=none
Pedro Alves wrote:
> On 03/29/2016 07:08 PM, Ulrich Weigand wrote:
>
> > However, there does seem to be one issue: your patch changes the
> > interface between gdbserver and the in-process agent in an incompatible
> > way. Binaries with an old IPA built in will no longer work with a
> > new gdbserver, since it will will expect exported symbols like
> > gdb_collect_ptr, which the old binary doesn't export.
> >
> > I think it would be preferable to implement a backward-compatible
> > way where gdbserver checks for the new symbol, and if it isn't
> > present, falls back to the old symbol.
>
> So far, given the tight coupling between gdbserver and the IPA's
> implementation, we've required that gdbserver and the IPA must
> be of the same version. We're added new functions to the
> interface before without trying to maintain backwards compatibility.
Ah, OK, I didn't realize that. That's fine with me as well.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com