This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Simplify gdb.reverse/until-reverse.c
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Tue, 29 Mar 2016 17:45:57 +0100
- Subject: Re: [PATCH] Simplify gdb.reverse/until-reverse.c
- Authentication-results: sourceware.org; auth=none
- References: <1459257423-9675-1-git-send-email-yao dot qi at linaro dot org>
On 03/29/2016 02:17 PM, Yao Qi wrote:
Nowadays, functions fprintf, printf and malloc are executed in
gdb.reverse/until-reverse.c, so that it takes much time to record
instructions inside them. This may cause timeout, and we had several
fixes to bump the timeout,
https://sourceware.org/ml/gdb-patches/2012-02/msg00038.html
https://sourceware.org/ml/gdb-patches/2015-08/msg00186.html
however, I can't figure out how these functions (fprintf, printf and
malloc) are related to the test itself. marker1 is a function from
shared library too so we don't need these complicated libc functions
at all. IMO, recording the instructions in these libc functions has
nothing to do with the test itself except slow down the test. This
patch is to remove the usage of fprintf and printf, and also move
malloc to a dead code path.
This is fine with me.
Thanks,
Pedro Alves