This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Suggest newer gdbserver if it has no qXfer:exec-file:read
- From: Gary Benson <gbenson at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 22 Mar 2016 09:15:27 +0000
- Subject: Re: [patch] Suggest newer gdbserver if it has no qXfer:exec-file:read
- Authentication-results: sourceware.org; auth=none
- References: <20160319201842 dot GA16540 at host1 dot jankratochvil dot net>
Jan Kratochvil wrote:
> gdb/ChangeLog
> 2016-03-19 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * remote.c (remote_pid_to_exec_file): Print warning for unsupported
> PACKET_qXfer_exec_file.
>
> diff --git a/gdb/remote.c b/gdb/remote.c
> index af0a08a..d267736 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -12977,7 +12977,13 @@ remote_pid_to_exec_file (struct target_ops *self, int pid)
> char *annex = NULL;
>
> if (packet_support (PACKET_qXfer_exec_file) != PACKET_ENABLE)
> - return NULL;
> + {
> + warning (_("No executable has been specified (see the \"file\" command) "
> + "and remote gdbserver does not "
> + "support packet \"qXfer:exec-file:read\""
> + " - please use FSF gdbserver version 7.10 or later."));
> + return NULL;
> + }
>
> if (filename != NULL)
> xfree (filename);
This looks good to me.
Thanks,
Gary
--
http://gbenson.net/