This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Commit: AArch64: Simulate scalar NEG and vector MUL

From: Mike Frysinger <vapier at gentoo dot org>
To: Nick Clifton <nickc at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Fri, 18 Mar 2016 09:27:18 -0400
Subject: Re: Commit: AArch64: Simulate scalar NEG and vector MUL
Authentication-results: sourceware.org; auth=none
References: <87io0kt9lt dot fsf at redhat dot com>

On 18 Mar 2016 09:32, Nick Clifton wrote:
> +#define GET_VEC_ELEMENT(REG, ELEMENT, FIELD)	   \

is using all caps for arg names a normal style thing ?

> +  do						   \
> +    {						   \
> +      if (element > ARRAY_SIZE (cpu->fr[0].FIELD)) \

shouldn't this be ELEMENT ?  and be >= ?

> +#define SET_VEC_ELEMENT(REG, ELEMENT, VAL, FIELD, PRINTER)	\
> +  do						   		\
> +    {								\
> +      if (ELEMENT > ARRAY_SIZE (cpu->fr[0].FIELD))			\

>= ?
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: Commit: AArch64: Simulate scalar NEG and vector MUL
  - From: Nick Clifton

References:
- Commit: AArch64: Simulate scalar NEG and vector MUL
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]