This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 0/3] Some cleanups in linux-record.c
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: gdb-patches at sourceware dot org
- Cc: Yao Qi <qiyaoltc at gmail dot com>, "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Date: Wed, 16 Mar 2016 19:54:34 +0100
- Subject: [PATCH 0/3] Some cleanups in linux-record.c
- Authentication-results: sourceware.org; auth=none
This is a follow-up to this patch:
https://sourceware.org/ml/gdb-patches/2016-03/msg00239.html
As pointed out by Markus Metzger, the added lines in that patch used
tabified indentation, whereas much of the existing code in the file used
spaces for indentation instead. He suggested to "either fix it for the
entire function in a separate patch or preserve the broken indentation."
This series implements the first option. While fixing the whitespace
issues I also found a bug and added a fix to this series as well.
Patch #1 fixes an inadvertent fall-through to the next case statement.
Patch #2 fixes all whitespace issues in linux-record.c. Patch #3 is a new
version of the original patch above, with the following improvements:
* Consequently keep invocations of record_mem_at_reg to a single line if
staying within the ("soft") limit of 74 chars.
* Remove braces in the handling for `readlink', since the block is not
needed anymore.
* Use record_mem_at_reg at two further places that were overlooked before.
Andreas Arnez (3):
linux-record: Fix bad fall-through for pipe/pipe2
linux-record.c: Fix whitespace issues
linux-record: Simplify with record_mem_at_reg()
gdb/linux-record.c | 2226 +++++++++++++++++++++++-----------------------------
1 file changed, 989 insertions(+), 1237 deletions(-)
--
2.5.0