This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/8] gdb/s390: Fill gen_return_address hook.
- From: Pedro Alves <palves at redhat dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, koriakin at 0x04 dot net, gdb-patches at sourceware dot org
- Date: Tue, 15 Mar 2016 11:30:26 +0000
- Subject: Re: [PATCH 4/8] gdb/s390: Fill gen_return_address hook.
- Authentication-results: sourceware.org; auth=none
- References: <1453637529-26972-5-git-send-email-koriakin at 0x04 dot net> <1454853751-18455-1-git-send-email-koriakin at 0x04 dot net> <m3bn6lz2fu dot fsf at oc1027705133 dot ibm dot com> <56E2AD82 dot 3060101 at 0x04 dot net> <m37fh9yzqn dot fsf at oc1027705133 dot ibm dot com> <56E2B95F dot 7050701 at 0x04 dot net> <m337rxyqt9 dot fsf at oc1027705133 dot ibm dot com> <56E2E7C8 dot 7050901 at redhat dot com> <m3y49px8tf dot fsf at oc1027705133 dot ibm dot com> <56E2FA1B dot 7050808 at redhat dot com> <83shzwj2wt dot fsf at gnu dot org> <56E31062 dot 7020707 at redhat dot com> <83h9gcizcb dot fsf at gnu dot org> <56E7EDCC dot 8040400 at redhat dot com> <m3ziu03ry9 dot fsf at oc1027705133 dot ibm dot com>
On 03/15/2016 11:23 AM, Andreas Arnez wrote:
> On Tue, Mar 15 2016, Pedro Alves wrote:
>
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index bf7df35..5f88335 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -12878,6 +12878,13 @@ Collect all local variables.
>> Collect the return address. This is helpful if you want to see more
>> of a backtrace.
>>
>> +@emph{Note:} The return address location can not always be reliability
> ^^^^^^^^^^^
> Should be "reliably" ;-)
Bah. I knew I'd forget something... Thanks for double checking.
Fixed with the patch below.
>From 2a60e18f8fe3bf9512671e02b39acacb484bb8c6 Mon Sep 17 00:00:00 2001
From: Pedro Alves <palves@redhat.com>
Date: Tue, 15 Mar 2016 11:29:03 +0000
Subject: [PATCH] Fix typo in previous gdb/doc/ commit
Should be s/reliability/reliably/.
gdb/doc/ChangeLog:
2016-03-15 Pedro Alves <palves@redhat.com>
* gdb.texinfo (Tracepoint Actions): Fix typo.
---
gdb/doc/ChangeLog | 4 ++++
gdb/doc/gdb.texinfo | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 0606d9d..a48d1c4 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,4 +1,8 @@
2016-03-15 Pedro Alves <palves@redhat.com>
+
+ * gdb.texinfo (Tracepoint Actions): Fix typo.
+
+2016-03-15 Pedro Alves <palves@redhat.com>
Andreas Arnez <arnez@linux.vnet.ibm.com>
Marcin KoÅcielnicki <koriakin@0x04.net>
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 5f88335..71657b0 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -12878,7 +12878,7 @@ Collect all local variables.
Collect the return address. This is helpful if you want to see more
of a backtrace.
-@emph{Note:} The return address location can not always be reliability
+@emph{Note:} The return address location can not always be reliably
determined up front, and the wrong address / registers may end up
collected instead. On some architectures the reliability is higher
for tracepoints at function entry, while on others it's the opposite.
--
2.5.0