This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/8] gdb/s390: Fill gen_return_address hook.
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Pedro Alves <palves at redhat dot com>
- Cc: arnez at linux dot vnet dot ibm dot com, koriakin at 0x04 dot net, gdb-patches at sourceware dot org
- Date: Fri, 11 Mar 2016 20:16:34 +0200
- Subject: Re: [PATCH 4/8] gdb/s390: Fill gen_return_address hook.
- Authentication-results: sourceware.org; auth=none
- References: <1453637529-26972-5-git-send-email-koriakin at 0x04 dot net> <1454853751-18455-1-git-send-email-koriakin at 0x04 dot net> <m3bn6lz2fu dot fsf at oc1027705133 dot ibm dot com> <56E2AD82 dot 3060101 at 0x04 dot net> <m37fh9yzqn dot fsf at oc1027705133 dot ibm dot com> <56E2B95F dot 7050701 at 0x04 dot net> <m337rxyqt9 dot fsf at oc1027705133 dot ibm dot com> <56E2E7C8 dot 7050901 at redhat dot com> <m3y49px8tf dot fsf at oc1027705133 dot ibm dot com> <56E2FA1B dot 7050808 at redhat dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Cc: Eli Zaretskii <eliz@gnu.org>,
> Marcin KoÅcielnicki
> <koriakin@0x04.net>,
> gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Fri, 11 Mar 2016 17:02:19 +0000
>
> > @item $_ret
> > Collect the return address. This is helpful if you want to see more
> > -of a backtrace.
> > +of a backtrace. Note that the return address can not always be
> > +determined reliably, and a wrong address may be collected instead.
> > +The reliability is usually higher for tracepoints at function entry.
>
> Hmm, this reads a bit as if the backtrace will be incorrect/bogus
> later on, which is not true.
>
> How about a merge of your suggestion with Marcin's previous reply,
> and some extras on top:
>
> @item $_ret
> Collect the set of memory addresses and/or registers necessary to compute
> the frame's return address. This is helpful if you want to see
> more of a backtrace.
>
> @emph{Note:} The necessary set can not always be reliability determined up
> front, and the wrong address / registers may end up collected instead.
> The reliability is usually higher for tracepoints at function entry.
> When this happens, backtracing will stop because the return address
> is found unavailable (unless another collect rule happened to match it).
Maybe it's me, but I don't see the significant difference between
these two versions. (And there's a typo in the second one:
"reliability" should be "reliably".)
Thanks.