This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 8/8] New test about step over clone syscall
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 25 Feb 2016 17:43:11 +0000
- Subject: Re: [PATCH 8/8] New test about step over clone syscall
- Authentication-results: sourceware.org; auth=none
- References: <1455892594-2294-1-git-send-email-yao dot qi at linaro dot org> <1455892594-2294-9-git-send-email-yao dot qi at linaro dot org>
On 02/19/2016 02:36 PM, Yao Qi wrote:
> + if { $syscall == "clone" } {
> + # Create a breakpoint in the child with the condition
> + # which is false, so that GDBserver can get the
> + # event from the child but GDB doesn't see it. In
> + # this way, we don't have to adjust test flow for
> + # "clone".
I think this comment should mention this is a regression test for
a previous bug. I'd file the description of patch #1 as a PR,
and reference the PR here. I had read that patch before this one,
and it took me a bit to see the connection.
> + gdb_test "break clone_fn if main == 0"
> + }
Thanks,
Pedro Alves