This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[patch, avr] Fix incorrect argument register for push dummy call

From: Pitchumani Sivanupandi <pitchumani dot s at atmel dot com>
To: <gdb-patches at sourceware dot org>
Date: Thu, 25 Feb 2016 18:04:49 +0530
Subject: [patch, avr] Fix incorrect argument register for push dummy call
Authentication-results: sourceware.org; auth=none

There are few failures for avr-gdb in callfuncs.exp. These failures are
due to the incorrect argument passing in case of push dummy call. The
last argument register is calculated incorrectly that caused this issue.

Attached patch fixes the calculation so that the push dummy call aligns
with the code generated by avr-gcc.

No new regressions found when tested with internal simulator.

If ok, could someone commit please?

Regards,
Pitchumani

gdb/ChangeLog

2016-02-25  Pitchumani Sivanupandi  <pitchumani.s@atmel.com>

	* avr-tdep.c (AVR_LAST_ARG_REGNUM): Define.
	(avr_push_dummy_call): Correct last needed argument register.

Attachment: avr-last-argument-register-fix.patch
Description: Text document

Follow-Ups:
- Re: [patch, avr] Fix incorrect argument register for push dummy call
  - From: Luis Machado

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]