This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.

From: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
To: Ulrich Weigand <uweigand at de dot ibm dot com>
Cc: lgustavo at codesourcery dot com, arnez at linux dot vnet dot ibm dot com, gdb-patches at sourceware dot org
Date: Thu, 18 Feb 2016 17:00:56 +0100
Subject: Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
Authentication-results: sourceware.org; auth=none
References: <20160218155844 dot 0D7D96B9A at oc7340732750 dot ibm dot com>

On 18/02/16 16:58, Ulrich Weigand wrote:

Marcin KoÅ›cielnicki wrote:

On 18/02/16 16:40, Ulrich Weigand wrote:

I don't think you actually need this include, do you?

Otherwise, this patch is OK.

Bye,
Ulrich


I do, the default_guess_tracepoint_registers function is declared there,
and gdbarch.c uses it.


Ah, right.  You should probably move the prototype to arch-utils.h
(and then the implementation to arch-utils.c) to go with the other
default_ functions.


Alright, I'll do that.


Since gdbarch.h is included everywhere, we try to avoid having it
include other headers as far as possible.

FWIW, the header include I added only ends up in gdbarch.c, .h isunaffected.


Bye,
Ulrich

Follow-Ups:
- Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
  - From: Ulrich Weigand

References:
- Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
  - From: Ulrich Weigand

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]