This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] arm-tdep.c: Refactor arm_decode_dp_misc

From: Yao Qi <qiyaoltc at gmail dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 11 Feb 2016 17:10:04 +0000
Subject: Re: [PATCH 2/3] arm-tdep.c: Refactor arm_decode_dp_misc
Authentication-results: sourceware.org; auth=none
References: <1455121027-27061-1-git-send-email-simon dot marchi at ericsson dot com> <1455121027-27061-3-git-send-email-simon dot marchi at ericsson dot com> <86h9hfpipt dot fsf at gmail dot com>

On 11/02/16 11:52, Yao Qi wrote:

In short, I don't see how this patch improve the readability of the
code, and I feel hard mapping the code to the manual.


s/ feel/ don't feel/

--
Yao (éå)

References:
- [PATCH 0/3] Minor refactorings in arm-tdep.c instruction decoding
  - From: Simon Marchi
- [PATCH 2/3] arm-tdep.c: Refactor arm_decode_dp_misc
  - From: Simon Marchi
- Re: [PATCH 2/3] arm-tdep.c: Refactor arm_decode_dp_misc
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]