RE: [PATCH v2 3/3] btrace, frame: fix crash in get_frame_type

["Metzger, Markus T" <markus dot t dot metzger at intel dot com>]

> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Thursday, February 11, 2016 4:58 PM
> To: Metzger, Markus T <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH v2 3/3] btrace, frame: fix crash in get_frame_type


> >> If we don't know where the caller is, we can't skip the resolver in
> >> one go, so best to do is probably to return 0, and let infrun's
> >> stepping logic continue single-stepping.
> >
> > You think we should add the check nevertheless in gdb/glibc-tdep.c?
> 
> Let's leave it be.  If may be that the use case that trips on it would be best
> fixed differently.
> 
> >
> > The others I won't be able to test.  I could do the changes and rely
> > on buildbot to flag issues.  If we really want to change them.
> 
> I don't think we should change the others without evidence that they'd need
> it.
> If we do trip on problems on those, I think the fix should be elsewhere.
> 
> I'd still early in the release cycle, let's wait and see.

OK.  I'll send the complete series again.

Pathes 1 and 2 are unchanged and you've seen almost everything of patch 3,
already.  Actually, patch 2 has been replaced by a completely unrelated patch,
but you've OK'ed it already in your last reply.

Thanks a lot for your review and for pointing out issues!

Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928