This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] gdb.trace: Read XML target description from tfile.
- From: Pedro Alves <palves at redhat dot com>
- To: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 10 Feb 2016 22:20:16 +0000
- Subject: Re: [PATCH 2/3] gdb.trace: Read XML target description from tfile.
- Authentication-results: sourceware.org; auth=none
- References: <56BB34FE dot 8040108 at redhat dot com> <1455135549-21872-1-git-send-email-koriakin at 0x04 dot net>
On 02/10/2016 08:19 PM, Marcin KoÅcielnicki wrote:
> gdb/ChangeLog:
>
> * tracefile-tfile.c (trace_tdesc): New static variable.
> (tfile_open): Clear trace_tdesc, call target_find_description.
> (tfile_interp_line): Recognize tdesc lines.
> (tfile_close): Clear trace_tdesc.
> (tfile_xfer_partial_features): New function.
> (tfile_xfer_partial): Call tfile_xfer_partial_features.
> (tfile_append_tdesc_line): New function.
> ---
> Fixes applied, buffer used.
Thanks. This is OK, with...
> +/* Handles tdesc lines from tfile by appending the payload to
> + a global trace_tdesc variable. */
> +
> +static void
> +tfile_append_tdesc_line (const char *line)
> +{
> + int llen = strlen (line);
> +
... this unused var dropped.
> + buffer_grow_str (&trace_tdesc, line);
> + buffer_grow_str (&trace_tdesc, "\n");
> +}
Thanks,
Pedro Alves