This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Clear *VAL in regcache_raw_read_unsigned
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 10 Feb 2016 16:52:43 +0000
- Subject: Re: [PATCH] Clear *VAL in regcache_raw_read_unsigned
- Authentication-results: sourceware.org; auth=none
- References: <1455029644-6197-1-git-send-email-yao dot qi at linaro dot org> <86egckqztq dot fsf at gmail dot com>
On 02/10/2016 04:45 PM, Yao Qi wrote:
> Yao Qi <qiyaoltc@gmail.com> writes:
>
>> Regression tests are still running. I'll push it in if there is no
>> regression in tests.
>>
>> gdb/gdbserver:
>>
>> 2016-02-09 Yao Qi <yao.qi@linaro.org>
>>
>> * regcache.c (regcache_raw_read_unsigned): Clear *VAL.
>
> Regression test on arm-linux is done. I push it in to both master and
> 7.11 branch. Note that this function is only used for software single
> step on arm-linux, so I run tests for arm-linux target.
Isn't this broken on big endian? AFAICS, we're reading 32-bits into
the higher 32-bits of a 64-bit variable.
Thanks,
Pedro Alves