This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix two misleading indentation warnings
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 29 Jan 2016 14:07:58 +0000
- Subject: Re: [PATCH] Fix two misleading indentation warnings
- Authentication-results: sourceware.org; auth=none
- References: <1454006626-10564-1-git-send-email-simon dot marchi at ericsson dot com>
Simon Marchi <simon.marchi@ericsson.com> writes:
Hi Simon,
> diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
> index 533a33a..938261a 100644
> --- a/gdb/xcoffread.c
> +++ b/gdb/xcoffread.c
> @@ -2381,13 +2381,13 @@ scan_xcoff_symtab (struct objfile *objfile)
> if (first_fun_line_offset == 0 && symbol.n_numaux > 1)
> first_fun_line_offset =
> main_aux[0].x_sym.x_fcnary.x_fcn.x_lnnoptr;
> - {
> - record_minimal_symbol
> - (namestring, symbol.n_value,
> - sclass == C_HIDEXT ? mst_file_text : mst_text,
> - symbol.n_scnum, objfile);
> - misc_func_recorded = 1;
> - }
> + {
> + record_minimal_symbol
> + (namestring, symbol.n_value,
> + sclass == C_HIDEXT ? mst_file_text : mst_text,
> + symbol.n_scnum, objfile);
> + misc_func_recorded = 1;
> + }
> break;
This looks an indentation issue. This block was added as a replacement
to RECORD_MINIMAL_SYMBOL which was indented correctly.
https://sourceware.org/ml/gdb-patches/2012-04/msg00440.html
A nit, can we remove the brackets ("{" and "}")? Change to xcoffread.c
looks good to me.
--
Yao (éå)