This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Reword the string description of native FreeBSD ptids.


The prior format led to confusing messages when threads were created
or added such as "[New process 14757, LWP 100537]".  The new format
reports this as "[New LWP 100434 of process 15652]".

gdb/ChangeLog:

	* fbsd-nat.c (fbsd_pid_to_str): Adjust string format.
---
 gdb/ChangeLog  | 4 ++++
 gdb/fbsd-nat.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 45d8ef9..008a6cd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2016-01-21  John Baldwin  <jhb@FreeBSD.org>
+
+	* fbsd-nat.c (fbsd_pid_to_str): Adjust string format.
+
 2016-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* disasm.c (maybe_add_dis_line_entry): Rename to...
diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index e7ca0e6..bdf078e 100644
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -303,7 +303,7 @@ fbsd_pid_to_str (struct target_ops *ops, ptid_t ptid)
       static char buf[64];
       int pid = ptid_get_pid (ptid);
 
-      xsnprintf (buf, sizeof buf, "process %d, LWP %d", pid, lwp);
+      xsnprintf (buf, sizeof buf, "LWP %d of process %d", lwp, pid);
       return buf;
     }
 
-- 
2.7.0

I believe I copied the earlier format from the bsd-uthread.c target.
Linux only reports the LWP.  Some other targets report both the process
and thread ID (such as Darwin).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]