This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix regression introduced in "break *<EXPR>" by explicit location patches
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 21 Jan 2016 14:33:21 +0400
- Subject: Re: [RFA] Fix regression introduced in "break *<EXPR>" by explicit location patches
- Authentication-results: sourceware.org; auth=none
- References: <20150805232802 dot 21646 dot 88440 dot stgit at valrhona dot uglyboxes dot com> <20150805232951 dot 21646 dot 67733 dot stgit at valrhona dot uglyboxes dot com> <20151214071113 dot GA6230 at adacore dot com> <566F2CF1 dot 1030003 at redhat dot com> <20151215133948 dot GA7938 at adacore dot com> <20160117153229 dot GF4059 at adacore dot com> <569D591C dot 5000509 at redhat dot com>
> On 01/17/2016 07:32 AM, Joel Brobecker wrote:
> > What do you think of the attached patch? There is also a testcase,
> > which is slightly different from the scenario that triggered this
> > exchange, but which also has the advantage of not requiring PIE,
> > which makes the test a little more universal, I think.
>
> This looks great to me. I say go for it.
>
> [Wow, you found a non-PIE reproducer. Way cool!]
:-). thanks for the review, Keith. I just pushed the patch.
> PS. I also note there was a "save breakpoints" bug related to this bug,
> too. I'll work on a separate submission for that. This is definitely
> should have some test coverage!
That would be nice indeed.
--
Joel