This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Limit breakpoint re-set to the current program space
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Mon, 18 Jan 2016 15:01:46 -0800
- Subject: Re: [PATCH] Limit breakpoint re-set to the current program space
- Authentication-results: sourceware.org; auth=none
- References: <1452645298-19600-1-git-send-email-palves at redhat dot com>
On 01/12/2016 04:34 PM, Pedro Alves wrote:
> Currently, we always re-set all locations of all breakpoints. This
> commit makes us re-set only locations of the current program space.
I'll come right out and say it: Damn! Why didn't I think of that?
You are no doubt aware (but other readers may not be), I've delved into
breakpoint_re_set optimization a bit, and published a branch and wiki
page for the (in-progress) work I've done.
[https://sourceware.org/gdb/wiki/BreakpointReset]
Your approach here is pretty much identical to the approach I took on my
breakpoint-reset project branch. So I cannot find any fault with that. ;-)
Your implementation, on the other hand, is, well, at least as good. :-)
Well done,
Keith