This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add micromips support to the MIPS simulator

From: Mike Frysinger <vapier at gentoo dot org>
To: Andrew Bennett <Andrew dot Bennett at imgtec dot com>
Cc: Maciej Rozycki <Maciej dot Rozycki at imgtec dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Steve Ellcey <Steve dot Ellcey at imgtec dot com>
Date: Fri, 15 Jan 2016 12:44:53 -0500
Subject: Re: [PATCH] Add micromips support to the MIPS simulator
Authentication-results: sourceware.org; auth=none
References: <0DA23CC379F5F945ACB41CF394B9827720F51185 at LEMAIL01 dot le dot imgtec dot org> <20150224054441 dot GA6655 at vapier> <0DA23CC379F5F945ACB41CF394B98277211129DE at LEMAIL01 dot le dot imgtec dot org> <20150917044236 dot GB6834 at vapier dot lan> <0DA23CC379F5F945ACB41CF394B9827721126A60 at LEMAIL01 dot le dot imgtec dot org> <20150925140742 dot GD21570 at vapier dot lan> <0DA23CC379F5F945ACB41CF394B98277211271C5 at LEMAIL01 dot le dot imgtec dot org> <alpine dot DEB dot 2 dot 00 dot 1601121840430 dot 5958 at tp dot orcam dot me dot uk> <0DA23CC379F5F945ACB41CF394B9827761B7E470 at LEMAIL01 dot le dot imgtec dot org>

On 15 Jan 2016 16:22, Andrew Bennett wrote:
> > As a microMIPS engine is not included in a mips-linux-gnu build the file
> > supposed to provide `micromips_instruction_decode' is not generated or
> > compiled, whereas `delayslot_micromips' (and a bunch of other functions)
> > is built unconditionally.
> > 
> >  Restricting the affected functions to microMIPS processors only has fixed
> > the build problem for me, see the patch below.  I have not verified it
> > further though, will you be able to look into it soon?
> 
> Hi Maciej,
> 
> The patch looks good, I noticed that the FMT_MICROMIPS, FMT_MICROMIPS_CVT_D
> and FMT_MICROMIPS_CVT_S functions also needed fixing.  I have built it for the 
> mips-elf, mips-linux-gnu and mips-mti-elf targets and they all build successfully.
> The updated patch and ChangeLog is below.
> 
> Ok to commit?

looks fine to me.  note that this is PR sim/19441 (which is assigned
to you), so you should note that in the ChangeLog/commit message.
-mike

Attachment: signature.asc
Description: Digital signature

References:
- RE: [PATCH] Add micromips support to the MIPS simulator
  - From: Maciej W. Rozycki
- RE: [PATCH] Add micromips support to the MIPS simulator
  - From: Andrew Bennett

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]