This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] sim: hw-properties: delete trace calls [committed]


These trace calls don't seem to add anything useful and break the cris
hw tests, so punt them.  They were disabled before commit 6d519a4606b9
but were re-enabled as part of TRACE macro cleanups.
---
 sim/common/ChangeLog       | 8 ++++++++
 sim/common/hw-properties.c | 4 ----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog
index e6ac042..3e6e3d9 100644
--- a/sim/common/ChangeLog
+++ b/sim/common/ChangeLog
@@ -1,5 +1,13 @@
 2015-12-25  Mike Frysinger  <vapier@gentoo.org>
 
+	* hw-properties.c (hw_find_ihandle_runtime_property): Delete
+	HW_TRACE call.
+	(hw_find_integer_property): Likewise.
+	(hw_find_integer_array_property): Likewise.
+	(hw_add_duplicate_property): Likewise.
+
+2015-12-25  Mike Frysinger  <vapier@gentoo.org>
+
 	* sim-config.h (WITH_ENGINE): Delete.
 	* sim-module.c (modules): Always include sim_engine_install.
 
diff --git a/sim/common/hw-properties.c b/sim/common/hw-properties.c
index d66873c..0aaebbd 100644
--- a/sim/common/hw-properties.c
+++ b/sim/common/hw-properties.c
@@ -417,7 +417,6 @@ hw_find_ihandle_runtime_property (struct hw *me,
 				  ihandle_runtime_property_spec *ihandle)
 {
   struct hw_property_data *entry = find_property_data (me, property);
-  HW_TRACE ((me, "hw_find_ihandle_runtime_property(property=%s)\n", property));
   if (entry == NULL)
     hw_abort (me, "property \"%s\" not found", property);
   if (entry->property->type != ihandle_property
@@ -489,7 +488,6 @@ hw_find_integer_property (struct hw *me,
 {
   const struct hw_property *node;
   signed_cell integer;
-  HW_TRACE ((me, "hw_find_integer(property=%s)\n", property));
   node = hw_find_property (me, property);
   if (node == NULL)
     hw_abort (me, "property \"%s\" not found", property);
@@ -509,7 +507,6 @@ hw_find_integer_array_property (struct hw *me,
   const struct hw_property *node;
   int sizeof_integer = sizeof (*integer);
   signed_cell *cell;
-  HW_TRACE ((me, "hw_find_integer(property=%s)\n", property));
 
   /* check things sane */
   node = hw_find_property (me, property);
@@ -879,7 +876,6 @@ hw_add_duplicate_property (struct hw *me,
 			   const struct hw_property *original)
 {
   struct hw_property_data *master;
-  HW_TRACE ((me, "hw_add_duplicate_property(property=%s, ...)\n", property));
   if (original->disposition != permenant_object)
     hw_abort (me, "Can only duplicate permenant objects");
   /* find the original's master */
-- 
2.6.2


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]