This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Per-inferior thread IDs
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 18 Dec 2015 21:36:37 +0200
- Subject: Re: [PATCH] Per-inferior thread IDs
- Authentication-results: sourceware.org; auth=none
- References: <1450206316-25680-1-git-send-email-palves at redhat dot com> <8337v333id dot fsf at gnu dot org> <5672B5D0 dot 6020806 at redhat dot com> <83a8p9yq0p dot fsf at gnu dot org> <56744C3A dot 3040407 at redhat dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 18 Dec 2015 18:11:06 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
>
> >> +@kindex thread @var{thread-id}
> >> +@item thread @var{thread-id}
> >> +Make thread ID @var{thread-id} the current thread. The command
> >> +argument @var{thread-id} is the internal @value{GDBN} thread ID, as
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >> shown in the first field of the @samp{info threads} display.
> >
> > Why not use "qualified thread ID" here?
>
> This is not always inferior-qualified. It depends on whether you
> created a second inferior, as described earlier in the thread IDs
> description:
>
> Until you create a second inferior, @value{GDBN} does not show the
> @var{inferior-num} part of thread IDs, even though you can always use
> the full @var{inferior-num}.@var{thread-num} form to refer to threads
> of inferior 1, the initial inferior.
>
> Should I drop "internal", perhaps?
Yes, I think so.
> In any case, I've added an example now:
>
> +Make thread ID @var{thread-id} the current thread. The command
> +argument @var{thread-id} is the internal @value{GDBN} thread ID, as
> +shown in the first field of the @samp{info threads} display, with or
> +without an inferior qualifier (e.g., @samp{2.1} or @samp{1}).
An example always helps, so this is even better.
> Thank you very much for the review and suggestions thus far.
> Here's an updated docs patch. Let me know how it looks.
LGTM, thanks.