This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 14 Dec 2015 16:39, Nick Clifton wrote: > PS. I would be happy to be a maintainer for the AArch64 sim, if that is > agreeable. sounds fine > +static uint64_t > +system_get (sim_cpu * cpu, unsigned op0, unsigned op1, unsigned crn, no space after the "*" > +static void > +do_mrs (sim_cpu * cpu) same here > + /* > if (uimm (aarch64_get_instr (cpu), 21, 20) == 0x1) > - /* MSR <sys-reg>, <Xreg>. */ > - return; > + do_msr (cpu); */ > HALT_NYI; > + return; should there be a TODO or some other note explaining why the code is commented out ? otherwise patch looks fine at a general level; i haven't looked at the ISA to verify correctness -mike
Attachment:
signature.asc
Description: Digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |