This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 2/2] Implement 'catch syscall' for gdbserver
- From: Josh Stone <jistone at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org, philippe dot waroquiers at skynet dot be, sergiodj at redhat dot com, palves at redhat dot com, xdje42 at gmail dot com
- Date: Fri, 4 Dec 2015 18:14:51 -0800
- Subject: Re: [PATCH v3 2/2] Implement 'catch syscall' for gdbserver
- Authentication-results: sourceware.org; auth=none
- References: <1448506425-24691-1-git-send-email-jistone at redhat dot com> <1449196006-13759-1-git-send-email-jistone at redhat dot com> <1449196006-13759-2-git-send-email-jistone at redhat dot com> <837fkuiovv dot fsf at gnu dot org>
On 12/04/2015 12:44 AM, Eli Zaretskii wrote:
>> From: Josh Stone <jistone@redhat.com>
>> Cc: philippe.waroquiers@skynet.be, sergiodj@redhat.com, palves@redhat.com, eliz@gnu.org, xdje42@gmail.com, Josh Stone <jistone@redhat.com>
>> Date: Thu, 3 Dec 2015 18:26:46 -0800
>>
>> This adds a new QCatchSyscalls packet to enable 'catch syscall', and new
>> stop reasons "syscall_entry" and "syscall_return" for those events. It
>> is currently only supported on Linux x86 and x86_64.
>>
>> gdb/ChangeLog:
>>
>> 2015-12-03 Josh Stone <jistone@redhat.com>
>> Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * NEWS (Changes since GDB 7.10): Mention QCatchSyscalls and new
>> GDBserver support for catch syscall.
>> * remote.c (PACKET_QCatchSyscalls): New enum.
>> (remote_set_syscall_catchpoint): New function.
>> (remote_protocol_features): New element for QCatchSyscalls.
>> (remote_parse_stop_reply): Parse syscall_entry/return stops.
>> (init_remote_ops): Install remote_set_syscall_catchpoint.
>> (_initialize_remote): Config QCatchSyscalls.
>> * linux-nat.h (struct lwp_info) <syscall_state>: Comment typo.
>>
>> gdb/doc/ChangeLog:
>>
>> 2015-12-03 Josh Stone <jistone@redhat.com>
>> Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * gdb.texinfo (Remote Configuration): List the QCatchSyscalls packet.
>> (Stop Reply Packets): List the syscall entry and return stop reasons.
>> (General Query Packets): Describe QCatchSyscalls, and add it to the
>> table and detailed list of stub features.
>
> Any changes since v2 in the documentation parts that require a fresh
> review?
I made the changes you requested in v2 -- v3 just has some
merge-resolution in NEWS. But Pedro has noted some more things to
document for the next round.