This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64


On 12/03/2015 02:27 PM, Yao Qi wrote:

> Thanks for running the test.  Could you test your patch against GDB git
> mainline please?  The patch will be applied to mainline, so we need to
> test it against mainline.

With current git master the result is the same: no noticeable changes between patched and unpatched version.

>> # of expected passes            32377
>> # of unexpected failures        85
>> # of unexpected successes       2
>> # of expected failures          72
>> # of unknown successes          2
>> # of known failures             62
>> # of untested testcases         36
>> # of unsupported tests          201
>>
>> And here's after my patch:
>>
>> # of expected passes            32378
>> # of unexpected failures        85
>> # of unexpected successes       2
>> # of expected failures          71
>> # of unknown successes          2
>> # of known failures             62
>> # of untested testcases         36
>> # of unsupported tests          201
>>
>> I.e. one "expected failure" less and one "expected pass" more. I'm not
>> sure how to interpret this result.
>>
> This may happen from time to time, especially in some gdb.threads tests.

For some reason such things happen with different individual tests almost on 
every `make check` here, be it patched or unpatched version.

>>>> gdb/ChangeLog:
>>>>
>>>>       * configure.host: Fix detection of x86_64 host when setting
>>>> floatformats
>>> This line is too long, the max is 74.  Sentence should be ended with ".".
>> Should I resend the whole original mail with this fixed?
> Please post the changelog entry only for the reference.

gdb/ChangeLog:

	* configure.host: Fix detection of x86_64 host when setting
	floatformats.

> If there is no regression in the GDB mainline tests, and no objections
> from other people in 3 days, your patch can go in.
>
> Do you have write access to git repository and FSF copyright assignment?
> If you don't have them, I can commit it for you as a tiny patch.
> However, if you want to contribute more patches, you need an FSF
> copyright assignment, and git write access, so that you can push by yourself.

I think I don't. How do I get them?
As for more patches, I'm going to make a regression test for this fix, as 
suggested by Pedro Alves in another email.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]