This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFA: AArch64 sim

From: Nick Clifton <nickc at redhat dot com>
To: gdb-patches at sourceware dot org, Mike Frysinger <vapier at gentoo dot org>
Date: Thu, 19 Nov 2015 14:51:49 +0000
Subject: Re: RFA: AArch64 sim
Authentication-results: sourceware.org; auth=none
References: <87vbe8hvfo dot fsf at redhat dot com> <87y4ih8ij4 dot fsf at redhat dot com> <20150716151902 dot GE5641 at vapier> <55A90CBA dot 40007 at redhat dot com> <20151110073245 dot GN5154 at vapier dot lan>

Hi Mike,

  Thanks for review.

i've posted a patch to clean up the others.  you should trim it from this
one in the meantime.


OK - I have done that.

i'm not seeing how this is cleaner.  when you call sim_engine_halt, the
code stops at that point.  there is no returning/etc... afterwards.

plus, when i look at some of these funcs, they only ever return READY.
which leads to a lot of return code paths that are pointless.

Okey dokey - I have now refactored the code, removing the StatusCodereturn value from lots of functions, and calling sim_engine_halt fromany location where a problem or break is encountered.

you should scan the files and trim trailing whitespace while you're at it.
sed -i -r 's:[[:space:]]+$::' *.[ch]


Also done.

Is this version OK ?

Cheers
  Nick

Attachment: aarch64.sim.patch.4.xz
Description: application/xz

Follow-Ups:
- Re: RFA: AArch64 sim
  - From: Mike Frysinger

References:
- Re: RFA: AArch64 sim
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]