This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH c++ 6/6] Add a cast in jit_target_read_impl
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
- Date: Thu, 29 Oct 2015 17:15:51 +0000
- Subject: Re: [PATCH c++ 6/6] Add a cast in jit_target_read_impl
- Authentication-results: sourceware.org; auth=none
- References: <1446123767-25046-1-git-send-email-simon dot marchi at polymtl dot ca> <1446123767-25046-7-git-send-email-simon dot marchi at polymtl dot ca>
On 10/29/2015 01:02 PM, Simon Marchi wrote:
> We could change the signature of the function. However, it would
> require changing gdb_target_read in jit-reader.h, which is an exported
> interface. It's probably better to just add a cast in our code than to
> break other people's code.
Agreed.
>
> gdb/ChangeLog:
>
> * jit.c (jit_target_read_impl): Add cast.
OK.
Thanks,
Pedro Alves