This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC][PATCH 09/15] gdb: Add relocate instruction helpers
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: henrik dot wallin at windriver dot com
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 27 Oct 2015 11:20:32 +0000
- Subject: Re: [RFC][PATCH 09/15] gdb: Add relocate instruction helpers
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1444820235 dot git dot henrik dot wallin at windriver dot com> <cover dot 1444820235 dot git dot henrik dot wallin at windriver dot com> <b3dfc6c9e6fdba064a0925c137723e63d3103362 dot 1444820235 dot git dot henrik dot wallin at windriver dot com>
henrik.wallin@windriver.com writes:
> The functions are used both when validating an instruction
> when the users sets a fast tracepoint and when relocating
> an instruction when gdbserver/ipa installs the jump pad.
>
> Currently all PC relative instructions are considered
> not relocatable.
>
> Futher improvements can be made by rewriting some of those
> instructions with alternative instructions.
>
> gdb/ChangeLog:
>
> * arm-tdep.c : Add relocate functionality to be used by fast
> tracepoint support.
You are relocating instructions in GDB side, which uses qRelocInsn
packet. Why don't you relocate them in GDBserver side? Search
aarch64_relocate_instruction in gdbserver/linux-aarch64-low.c, and you
may have some clues from it.
--
Yao (éå)