This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] (patch 2/4, v2) [nto] Fixes for nto procfs.
- From: Pedro Alves <palves at redhat dot com>
- To: Aleksandar Ristovski <aristovski at qnx dot com>, gdb-patches at sourceware dot org
- Date: Tue, 20 Oct 2015 16:02:53 +0100
- Subject: Re: [PATCH 1/3] (patch 2/4, v2) [nto] Fixes for nto procfs.
- Authentication-results: sourceware.org; auth=none
- References: <56263FED dot 3050602 at redhat dot com> <1445351294-18179-1-git-send-email-aristovski at qnx dot com> <1445351294-18179-2-git-send-email-aristovski at qnx dot com>
On 10/20/2015 03:28 PM, Aleksandar Ristovski wrote:
> Fix errnoeus construction of procfs path. The issue is, after the first
> info pidlist or first run, the path for local node (the most common node)
> will be reset to empty which makes subsequent queries and runs impossible.
Thanks.
>
> gdb/ChangeLog:
>
> * nto-procfs.c (nto_procfs_path): Rename to...
> (nodestr): ... this, and change type.
> (nto_node): Use new variable and logic accordingly.
> (procfs_open_1): Use new variable name. Use local buffer to construct
> procfrs path.
> (procfs_pidlist): Use NODESTR to construct procfs path.
> (procfs_files_info): Use NODESTR to output meaningful text.
> (do_attach): Construct procfs using NODESTR.
> (procfs_create_inferior): Compare pointer to NULL.
This is OK.
There are some bits here that seem a bit unrelated, but we're
hitting the point of diminishing returns.
Thanks,
Pedro Alves