This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC][PATCH 01/15] Fix endian problem for tracepoint enabled flag
- From: Pedro Alves <palves at redhat dot com>
- To: henrik dot wallin at windriver dot com, gdb-patches at sourceware dot org
- Date: Thu, 15 Oct 2015 18:16:04 +0100
- Subject: Re: [RFC][PATCH 01/15] Fix endian problem for tracepoint enabled flag
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1444820235 dot git dot henrik dot wallin at windriver dot com> <c6583915ec9ce800b88769723b49d0d1ad394863 dot 1444820235 dot git dot henrik dot wallin at windriver dot com>
On 10/14/2015 12:14 PM, henrik.wallin@windriver.com wrote:
> From: Par Olsson <par.olsson@windriver.com>
>
> When running big endian machines there is a problem with
> the enabled flag for tracepoints as it is defined as a
> int8_t but written from gdbserver as an integer and then
> read in the agent as 8-bit value.
> This caused problem when tracepoint was disabled and
> re-enabled.
>
> gdb/gdbserver/ChangeLog:
>
> * tracepoint.c (struct tracepoint): Change type of enabled.
Seems wasteful for no obvious reason. Why not make gdbserver write
one byte then?
Thanks,
Pedro Alves