Re: [PATCH v2 1/7] Add breakpoint_from_pc target_ops for software breakpoints in GDBServer.

[Antoine Tremblay <antoine dot tremblay at ericsson dot com>]

On 10/15/2015 11:33 AM, Pedro Alves wrote:
> On 10/05/2015 05:44 PM, Antoine Tremblay wrote:
> > +static const unsigned char *
>
> gdb_byte?
>
> > +aarch64_breakpoint_from_pc (CORE_ADDR *pcptr, int *len)
> > +{
> > +  *len = aarch64_breakpoint_len;
> > +  return (const unsigned char *) &aarch64_breakpoint;
>
> ... and then this cast goes away.
>
> > +}
> > +
Ouch indeed that was very wrong , I also fixed bfin, m68k, s390 and 
sparc that had the same kind of issue.

> > +static const unsigned char *
> > +arm_breakpoint_from_pc (CORE_ADDR *pcptr, int *len)
> > +{
>
> Missing '/* Implementation of ... */' comment.
Done.

> > +}
> >   struct linux_target_ops the_low_target = {
>
> Missing empty line.
Done.
> > +
> > +  /* Return the raw breakpoint for this target based on PC.  The PCPTR is
> > +     ajusted to the real memory location in case a flag was present in the
>
> "adjusted".  Suggest an example, like "a flag (e.g., the Thumb bit on ARM) was"
Done.
> > +     PC.  */
> > +  const unsigned char *(*breakpoint_from_pc) (CORE_ADDR *pcptr, int *lenptr);
>
> Thanks,
> Pedro Alves