This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/7] Add breakpoint_from_kind target_ops for software breakpoints in GDBServer.
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 15 Oct 2015 10:04:03 +0100
- Subject: Re: [PATCH v2 2/7] Add breakpoint_from_kind target_ops for software breakpoints in GDBServer.
- Authentication-results: sourceware.org; auth=none
- References: <1444063455-31558-1-git-send-email-antoine dot tremblay at ericsson dot com> <1444063455-31558-3-git-send-email-antoine dot tremblay at ericsson dot com>
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
> index 603819e..74fb36d 100644
> --- a/gdb/gdbserver/target.h
> +++ b/gdb/gdbserver/target.h
> @@ -446,6 +446,10 @@ struct target_ops
> can be NULL, the default breakpoint for the target should be returned in
> this case. */
> const unsigned char *(*breakpoint_from_pc) (CORE_ADDR *pcptr, int *lenptr);
> +
> + /* Returns a breakpoint from a kind, a kind is a length can have target
> + specific meaning like the z0 kind parameter. */
> + const unsigned char *(*breakpoint_from_kind) (int *kind);
> };
Since this function is used for software breakpoint, how about renaming
it to software_breakpoint_from_kind? Sorry that I didn't raise this up
in the review lats time.
Otherwise it is OK.
--
Yao (éå)