This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: AIX DWARF debugging sections
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Doug Evans <dje at google dot com>, Tristan Gingold <gingold at adacore dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Tue, 13 Oct 2015 11:33:50 -0400
- Subject: Re: AIX DWARF debugging sections
- Authentication-results: sourceware.org; auth=none
- References: <CADPb22RhyhWrxLu2vy-TOp7ua97BWBJ6Loa9puoSFiYZq82NBg at mail dot gmail dot com> <20151006165157 dot GA3341 at adacore dot com> <CAGWvnykS9J5cHfbDg4swVhXZdJ+Lzk7JQmikbPrXh2E4p-xshg at mail dot gmail dot com> <CADPb22Q1s4q7NCzUO5iLt0cT8ewH21RhmHTnyPh7AS=4nhFmsw at mail dot gmail dot com> <CAGWvnymgdDdzeKNDrjrwwTnO9dPrkcfJjOhJJn9RjGX_+BheJQ at mail dot gmail dot com> <20151010000433 dot GB3341 at adacore dot com> <CADPb22QmuPeP_QBDNWA4iSi1jsnTvAiAurV8HWGCAYnPoMr+wg at mail dot gmail dot com> <CAGWvnyn51SPQeHvS3xNmc+9J8VwXiL1d94uVR84z_=4EYwdF+Q at mail dot gmail dot com> <20151012155021 dot GC3341 at adacore dot com> <CAGWvny=kgerJJokbsBz=h=1icH90ePjRCHzpi+GM+_nbiiuhjQ at mail dot gmail dot com> <20151012183438 dot GE3341 at adacore dot com>
On Mon, Oct 12, 2015 at 2:34 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> Thanks, David
>>
>> * xcoffread (dwrf2_xcoff_names): Add .dwmac and .dwpbtyp.
>
> Looks good to me with just one nit.
> the GNU Coding Standards ask us that sentences end with a period. So
> unfortunately, we're going to have to split that line in two.
For full sentences, we might as well document it more completely.
Thanks, David
diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index 0d49751..e4af37c 100644
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -159,11 +159,14 @@ static const struct dwarf2_debug_sections dwarf2_xcoff_nam
es = {
{ ".dwabrev", NULL },
{ ".dwline", NULL },
{ ".dwloc", NULL },
- { NULL, NULL }, /* debug_macinfo */
- { NULL, NULL }, /* debug_macro */
+ /* AIX XCOFF defines one, named DWARF section for macro debug information.
+ XLC does not generate debug_macinfo for DWARF4 and below.
+ The section is assigned to debug_macro for DWARF5 and above. */
+ { NULL, NULL },
+ { ".dwmac", NULL },
{ ".dwstr", NULL },
{ ".dwrnges", NULL },
- { NULL, NULL }, /* debug_types */
+ { ".dwpbtyp", NULL },
{ NULL, NULL }, /* debug_addr */
{ ".dwframe", NULL },
{ NULL, NULL }, /* eh_frame */